Skip to content

Commit

Permalink
perf buildid-list: Fix error return for success
Browse files Browse the repository at this point in the history
It was always returning -1 (255), confusing test scripts.

Reported-by: Han Pingtian <phan@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Han Pingtian <phan@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Dec 16, 2010
1 parent 68a7a77 commit bbde588
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/perf/builtin-buildid-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ static const struct option options[] = {

static int __cmd_buildid_list(void)
{
int err = -1;
struct perf_session *session;

session = perf_session__new(input_name, O_RDONLY, force, false);
Expand All @@ -49,7 +48,7 @@ static int __cmd_buildid_list(void)
perf_session__fprintf_dsos_buildid(session, stdout, with_hits);

perf_session__delete(session);
return err;
return 0;
}

int cmd_buildid_list(int argc, const char **argv, const char *prefix __used)
Expand Down

0 comments on commit bbde588

Please sign in to comment.