Skip to content

Commit

Permalink
de2104x: wrong MAC address fix
Browse files Browse the repository at this point in the history
The de2104x returns sometimes a wrong MAC address. The wrong one is
like the original one, but it comes with an one byte shift. I found
this bug on an older alpha ev5 cpu. More details are available in Gentoo
bugreport #240718.

It seems the hardware is sometimes a little bit too slow for an
immediate access. This patch solves the problem by introducing a small
udelay.

Signed-off-by: Martin Langer <martin-langer@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Martin Langer authored and David S. Miller committed Oct 14, 2008
1 parent ebe05d0 commit bc0da3f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/tulip/de2104x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1688,6 +1688,7 @@ static void __devinit de21040_get_mac_address (struct de_private *de)
unsigned i;

dw32 (ROMCmd, 0); /* Reset the pointer with a dummy write. */
udelay(5);

for (i = 0; i < 6; i++) {
int value, boguscnt = 100000;
Expand Down

0 comments on commit bc0da3f

Please sign in to comment.