Skip to content

Commit

Permalink
zram: constify attribute_group structures.
Browse files Browse the repository at this point in the history
attribute_groups are not supposed to change at runtime.  All functions
working with attribute_groups provided by <linux/sysfs.h> work with
const attribute_group.  So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   8293	    841	      4	   9138	   23b2	drivers/block/zram/zram_drv.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   8357	    777	      4	   9138	   23b2	drivers/block/zram/zram_drv.o

Link: http://lkml.kernel.org/r/65680c1c4d85818f7094cbfa31c91bf28185ba1b.1499061182.git.arvind.yadav.cs@gmail.com
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Arvind Yadav authored and Linus Torvalds committed Jul 10, 2017
1 parent 9d1f4b3 commit bc1bb36
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/block/zram/zram_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,7 @@ static struct attribute *zram_disk_attrs[] = {
NULL,
};

static struct attribute_group zram_disk_attr_group = {
static const struct attribute_group zram_disk_attr_group = {
.attrs = zram_disk_attrs,
};

Expand Down

0 comments on commit bc1bb36

Please sign in to comment.