Skip to content

Commit

Permalink
netxen: fix lro buffer allocation
Browse files Browse the repository at this point in the history
Alloc 12k skbuffs so that firmware can aggregate more
packets into one buffer. This doesn't raise memory
consumption since 9k skbs use 16k slab cache anyway.

Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dhananjay Phadke authored and David S. Miller committed Sep 4, 2009
1 parent d4ab881 commit bc75e5b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions drivers/net/netxen/netxen_nic.h
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@
#define NX_P2_RX_JUMBO_BUF_MAX_LEN (NX_MAX_ETHERHDR + P2_MAX_MTU)
#define NX_P3_RX_JUMBO_BUF_MAX_LEN (NX_MAX_ETHERHDR + P3_MAX_MTU)
#define NX_CT_DEFAULT_RX_BUF_LEN 2048
#define NX_LRO_BUFFER_EXTRA 2048

#define NX_RX_LRO_BUFFER_LENGTH (8060)

Expand Down
8 changes: 6 additions & 2 deletions drivers/net/netxen/netxen_nic_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,10 @@ int netxen_alloc_sw_resources(struct netxen_adapter *adapter)
else
rds_ring->dma_size =
NX_P2_RX_JUMBO_BUF_MAX_LEN;

if (adapter->capabilities & NX_CAP0_HW_LRO)
rds_ring->dma_size += NX_LRO_BUFFER_EXTRA;

rds_ring->skb_size =
rds_ring->dma_size + NET_IP_ALIGN;
break;
Expand Down Expand Up @@ -1217,6 +1221,7 @@ netxen_process_rcv(struct netxen_adapter *adapter,
if (pkt_offset)
skb_pull(skb, pkt_offset);

skb->truesize = skb->len + sizeof(struct sk_buff);
skb->protocol = eth_type_trans(skb, netdev);

napi_gro_receive(&sds_ring->napi, skb);
Expand Down Expand Up @@ -1278,8 +1283,7 @@ netxen_process_lro(struct netxen_adapter *adapter,

skb_put(skb, lro_length + data_offset);

skb->truesize = (skb->len + sizeof(struct sk_buff) +
((unsigned long)skb->data - (unsigned long)skb->head));
skb->truesize = skb->len + sizeof(struct sk_buff) + skb_headroom(skb);

skb_pull(skb, l2_hdr_offset);
skb->protocol = eth_type_trans(skb, netdev);
Expand Down

0 comments on commit bc75e5b

Please sign in to comment.