Skip to content

Commit

Permalink
soc: imx: gpc: remove unnecessary readable_reg callback
Browse files Browse the repository at this point in the history
It is not really necessary to provide the current .readable_reg
implementation as we know what we're doing in our driver
and the regmap core has already done the partial check for
available maximum regs.

Acked-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
  • Loading branch information
Dong Aisheng authored and Shawn Guo committed Mar 24, 2017
1 parent ff693a3 commit bd01f06
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/soc/imx/gpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,18 +284,10 @@ static const struct of_device_id imx_gpc_dt_ids[] = {
{ }
};

static bool imx_gpc_readable_reg(struct device *dev, unsigned int reg)
{
return (reg % 4 == 0) && (reg <= 0x2ac);
}

static const struct regmap_config imx_gpc_regmap_config = {
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,

.readable_reg = imx_gpc_readable_reg,

.max_register = 0x2ac,
};

Expand Down

0 comments on commit bd01f06

Please sign in to comment.