Skip to content

Commit

Permalink
ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback
Browse files Browse the repository at this point in the history
axg_card_add_tdm_loopback() misses to call kfree() in an error path. We
can use devm_kasprintf() to fix the issue, also improve maintainability.
So use it instead.

Fixes: c84836d ("ASoC: meson: axg-card: use modern dai_link style")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200717082242.130627-1-jingxiangfeng@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Jing Xiangfeng authored and Mark Brown committed Jul 17, 2020
1 parent fe0a530 commit bd054ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/meson/axg-card.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card *card,

lb = &card->dai_link[*index + 1];

lb->name = kasprintf(GFP_KERNEL, "%s-lb", pad->name);
lb->name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-lb", pad->name);
if (!lb->name)
return -ENOMEM;

Expand Down

0 comments on commit bd054ec

Please sign in to comment.