Skip to content

Commit

Permalink
perf evlist: Remove unused perf_evlist__fprintf() method
Browse files Browse the repository at this point in the history
Ditch it, noone is using it, one more stdio.h include in a hot header.

Fix the fallout in parse-events.y, where we end up using a FILE pointer,
I think due to YYDEBUG being set and in some places, like Amazon Linux 1
we don't get stdio.h included by luck, like in most other places, add a
explicit stdio.h include directive.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-37k5q0lhdbo2hvvfbnnzn7og@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Sep 25, 2019
1 parent ca12527 commit bd70462
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
13 changes: 0 additions & 13 deletions tools/perf/util/evlist.c
Original file line number Diff line number Diff line change
Expand Up @@ -1421,19 +1421,6 @@ int perf_evlist__parse_sample_timestamp(struct evlist *evlist,
return perf_evsel__parse_sample_timestamp(evsel, event, timestamp);
}

size_t perf_evlist__fprintf(struct evlist *evlist, FILE *fp)
{
struct evsel *evsel;
size_t printed = 0;

evlist__for_each_entry(evlist, evsel) {
printed += fprintf(fp, "%s%s", evsel->idx ? ", " : "",
perf_evsel__name(evsel));
}

return printed + fprintf(fp, "\n");
}

int perf_evlist__strerror_open(struct evlist *evlist,
int err, char *buf, size_t size)
{
Expand Down
3 changes: 0 additions & 3 deletions tools/perf/util/evlist.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <linux/refcount.h>
#include <linux/list.h>
#include <api/fd/array.h>
#include <stdio.h>
#include <internal/evlist.h>
#include <internal/evsel.h>
#include "events_stats.h"
Expand Down Expand Up @@ -249,8 +248,6 @@ static inline struct evsel *evlist__last(struct evlist *evlist)
return container_of(evsel, struct evsel, core);
}

size_t perf_evlist__fprintf(struct evlist *evlist, FILE *fp);

int perf_evlist__strerror_open(struct evlist *evlist, int err, char *buf, size_t size);
int perf_evlist__strerror_mmap(struct evlist *evlist, int err, char *buf, size_t size);

Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/parse-events.y
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#define YYDEBUG 1

#include <fnmatch.h>
#include <stdio.h>
#include <linux/compiler.h>
#include <linux/list.h>
#include <linux/types.h>
Expand Down

0 comments on commit bd70462

Please sign in to comment.