Skip to content

Commit

Permalink
NFC: st-nci: remove duplicated skb dump
Browse files Browse the repository at this point in the history
Remove SPI_DUMP_SKB and I2C_DUMP_SKB as skb is already dumped
in ndlc layer.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Christophe Ricard authored and Samuel Ortiz committed Oct 27, 2015
1 parent bb2496c commit bd8f1a3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
11 changes: 0 additions & 11 deletions drivers/nfc/st-nci/i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,6 @@ struct st_nci_i2c_phy {
struct st_nci_se_status se_status;
};

#define I2C_DUMP_SKB(info, skb) \
do { \
pr_debug("%s:\n", info); \
print_hex_dump(KERN_DEBUG, "i2c: ", DUMP_PREFIX_OFFSET, \
16, 1, (skb)->data, (skb)->len, 0); \
} while (0)

static int st_nci_i2c_enable(void *phy_id)
{
struct st_nci_i2c_phy *phy = phy_id;
Expand Down Expand Up @@ -101,8 +94,6 @@ static int st_nci_i2c_write(void *phy_id, struct sk_buff *skb)
struct st_nci_i2c_phy *phy = phy_id;
struct i2c_client *client = phy->i2c_dev;

I2C_DUMP_SKB("st_nci_i2c_write", skb);

if (phy->ndlc->hard_fault != 0)
return phy->ndlc->hard_fault;

Expand Down Expand Up @@ -173,8 +164,6 @@ static int st_nci_i2c_read(struct st_nci_i2c_phy *phy,
skb_put(*skb, len);
memcpy((*skb)->data + ST_NCI_I2C_MIN_SIZE, buf, len);

I2C_DUMP_SKB("i2c frame read", *skb);

return 0;
}

Expand Down
11 changes: 0 additions & 11 deletions drivers/nfc/st-nci/spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,6 @@ struct st_nci_spi_phy {
struct st_nci_se_status se_status;
};

#define SPI_DUMP_SKB(info, skb) \
do { \
pr_debug("%s:\n", info); \
print_hex_dump(KERN_DEBUG, "spi: ", DUMP_PREFIX_OFFSET, \
16, 1, (skb)->data, (skb)->len, 0); \
} while (0)

static int st_nci_spi_enable(void *phy_id)
{
struct st_nci_spi_phy *phy = phy_id;
Expand Down Expand Up @@ -110,8 +103,6 @@ static int st_nci_spi_write(void *phy_id, struct sk_buff *skb)
.len = skb->len,
};

SPI_DUMP_SKB("st_nci_spi_write", skb);

if (phy->ndlc->hard_fault != 0)
return phy->ndlc->hard_fault;

Expand Down Expand Up @@ -188,8 +179,6 @@ static int st_nci_spi_read(struct st_nci_spi_phy *phy,
skb_put(*skb, len);
memcpy((*skb)->data + ST_NCI_SPI_MIN_SIZE, buf, len);

SPI_DUMP_SKB("spi frame read", *skb);

return 0;
}

Expand Down

0 comments on commit bd8f1a3

Please sign in to comment.