Skip to content

Commit

Permalink
net/mlx5e: Remove redundant assignment
Browse files Browse the repository at this point in the history
Remove redundant assignment to tun_entropy->enabled.

Addesses-Coverity-ID: 1477328 ("Unused value")
Fixes: 97417f6 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Eli Britstein <elibr@mellanox.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
  • Loading branch information
Gustavo A. R. Silva authored and Saeed Mahameed committed Mar 22, 2019
1 parent ee576ec commit bdde931
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy,
mlx5_query_port_tun_entropy(mdev, &entropy_flags);
tun_entropy->num_enabling_entries = 0;
tun_entropy->num_disabling_entries = 0;
tun_entropy->enabled = entropy_flags.calc_enabled;
tun_entropy->enabled =
(entropy_flags.calc_supported) ?
entropy_flags.calc_enabled : true;
tun_entropy->enabled = entropy_flags.calc_supported ?
entropy_flags.calc_enabled : true;
}

static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy,
Expand Down

0 comments on commit bdde931

Please sign in to comment.