Skip to content

Commit

Permalink
atm: horizon: Fix irq release error
Browse files Browse the repository at this point in the history
atm_dev_register() can fail here and passed parameters to free irq
which is not initialised. Initialization of 'dev->irq' happened after
the 'goto out_free_irq'. So using 'irq' insted of 'dev->irq' in
free_irq().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Arvind Yadav authored and David S. Miller committed Nov 14, 2017
1 parent c92eb77 commit bde533f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/atm/horizon.c
Original file line number Diff line number Diff line change
Expand Up @@ -2803,7 +2803,7 @@ static int hrz_probe(struct pci_dev *pci_dev,
return err;

out_free_irq:
free_irq(dev->irq, dev);
free_irq(irq, dev);
out_free:
kfree(dev);
out_release:
Expand Down

0 comments on commit bde533f

Please sign in to comment.