Skip to content

Commit

Permalink
perf: Always record tracepoints raw samples from perf record
Browse files Browse the repository at this point in the history
Trace events are mostly used for tracing rather than simple
counting. Don't bother anymore with adding -R when using them,
just record raw samples of trace events every time.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Frederic Weisbecker committed Apr 15, 2010
1 parent 7865e81 commit bdef3b0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion tools/perf/Documentation/perf-record.txt
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ OPTIONS

-R::
--raw-samples::
Collect raw sample records from all opened counters (typically for tracepoint counters).
Collect raw sample records from all opened counters (default for tracepoint counters).

SEE ALSO
--------
Expand Down
14 changes: 4 additions & 10 deletions tools/perf/util/parse-events.c
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ static enum event_result
parse_single_tracepoint_event(char *sys_name,
const char *evt_name,
unsigned int evt_length,
char *flags,
struct perf_event_attr *attr,
const char **strp)
{
Expand All @@ -419,13 +418,9 @@ parse_single_tracepoint_event(char *sys_name,
u64 id;
int fd;

if (flags) {
if (!strncmp(flags, "record", strlen(flags))) {
attr->sample_type |= PERF_SAMPLE_RAW;
attr->sample_type |= PERF_SAMPLE_TIME;
attr->sample_type |= PERF_SAMPLE_CPU;
}
}
attr->sample_type |= PERF_SAMPLE_RAW;
attr->sample_type |= PERF_SAMPLE_TIME;
attr->sample_type |= PERF_SAMPLE_CPU;

snprintf(evt_path, MAXPATHLEN, "%s/%s/%s/id", debugfs_path,
sys_name, evt_name);
Expand Down Expand Up @@ -533,8 +528,7 @@ static enum event_result parse_tracepoint_event(const char **strp,
flags);
} else
return parse_single_tracepoint_event(sys_name, evt_name,
evt_length, flags,
attr, strp);
evt_length, attr, strp);
}

static enum event_result
Expand Down

0 comments on commit bdef3b0

Please sign in to comment.