Skip to content

Commit

Permalink
platform/x86: dell-smo8800: Use min_t() for comparison and assignment
Browse files Browse the repository at this point in the history
Simplify code by using min_t helper macro for logical evaluation
and value assignment. Use the _t variant of min macro since the
variable types are not same.
This issue is identified by coccicheck using the minmax.cocci file.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/Y9P8debIztOZXazW@ubun2204.myguest.virtualbox.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
Deepak R Varma authored and Hans de Goede committed Feb 3, 2023
1 parent cf2cc54 commit bdf2ffb
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/platform/x86/dell/dell-smo8800.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,7 @@ static ssize_t smo8800_misc_read(struct file *file, char __user *buf,

retval = 1;

if (data < 255)
byte_data = data;
else
byte_data = 255;
byte_data = min_t(u32, data, 255);

if (put_user(byte_data, buf))
retval = -EFAULT;
Expand Down

0 comments on commit bdf2ffb

Please sign in to comment.