Skip to content

Commit

Permalink
[ARM] OMAP clock: drop clk_get_usecount()
Browse files Browse the repository at this point in the history
This function is race-prone and mistakenly conveys the impression to
drivers that it is part of the clock interface.  Get rid of it: core
code that absolutely needs this can just check clk->usecount.  Drivers
should not use it at all.

linux-omap source commit is 5df9e4adc2f6a6d55aca53ee27b8baad18897c05.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Paul Walmsley authored and Russell King committed Feb 8, 2009
1 parent f11fda6 commit be5f34b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
16 changes: 0 additions & 16 deletions arch/arm/plat-omap/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,22 +76,6 @@ void clk_disable(struct clk *clk)
}
EXPORT_SYMBOL(clk_disable);

int clk_get_usecount(struct clk *clk)
{
unsigned long flags;
int ret = 0;

if (clk == NULL || IS_ERR(clk))
return 0;

spin_lock_irqsave(&clockfw_lock, flags);
ret = clk->usecount;
spin_unlock_irqrestore(&clockfw_lock, flags);

return ret;
}
EXPORT_SYMBOL(clk_get_usecount);

unsigned long clk_get_rate(struct clk *clk)
{
unsigned long flags;
Expand Down
1 change: 0 additions & 1 deletion arch/arm/plat-omap/include/mach/clock.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ extern void clk_unregister(struct clk *clk);
extern void propagate_rate(struct clk *clk);
extern void recalculate_root_clocks(void);
extern void followparent_recalc(struct clk *clk);
extern int clk_get_usecount(struct clk *clk);
extern void clk_enable_init_clocks(void);
#ifdef CONFIG_CPU_FREQ
extern void clk_init_cpufreq_table(struct cpufreq_frequency_table **table);
Expand Down

0 comments on commit be5f34b

Please sign in to comment.