Skip to content

Commit

Permalink
rtc: m41t80: remove debug sysfs attribute
Browse files Browse the repository at this point in the history
The last remaining sysfs attribute is undocumented and useless as it can
only be used to debug the driver. Remove it.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
  • Loading branch information
Alexandre Belloni committed Aug 24, 2017
1 parent d4473b9 commit be8e274
Showing 1 changed file with 0 additions and 44 deletions.
44 changes: 0 additions & 44 deletions drivers/rtc/rtc-m41t80.c
Original file line number Diff line number Diff line change
Expand Up @@ -440,28 +440,6 @@ static int m41t80_resume(struct device *dev)

static SIMPLE_DEV_PM_OPS(m41t80_pm, m41t80_suspend, m41t80_resume);

static ssize_t flags_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct i2c_client *client = to_i2c_client(dev);
int val;

val = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS);
if (val < 0)
return val;
return sprintf(buf, "%#x\n", val);
}
static DEVICE_ATTR_RO(flags);

static struct attribute *attrs[] = {
&dev_attr_flags.attr,
NULL,
};

static struct attribute_group attr_group = {
.attrs = attrs,
};

#ifdef CONFIG_COMMON_CLK
#define sqw_to_m41t80_data(_hw) container_of(_hw, struct m41t80_data, sqw)

Expand Down Expand Up @@ -912,13 +890,6 @@ static struct notifier_block wdt_notifier = {
*****************************************************************************
*/

static void m41t80_remove_sysfs_group(void *_dev)
{
struct device *dev = _dev;

sysfs_remove_group(&dev->kobj, &attr_group);
}

static int m41t80_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
Expand Down Expand Up @@ -1015,21 +986,6 @@ static int m41t80_probe(struct i2c_client *client,
return rc;
}

/* Export sysfs entries */
rc = sysfs_create_group(&(&client->dev)->kobj, &attr_group);
if (rc) {
dev_err(&client->dev, "Failed to create sysfs group: %d\n", rc);
return rc;
}

rc = devm_add_action_or_reset(&client->dev, m41t80_remove_sysfs_group,
&client->dev);
if (rc) {
dev_err(&client->dev,
"Failed to add sysfs cleanup action: %d\n", rc);
return rc;
}

#ifdef CONFIG_RTC_DRV_M41T80_WDT
if (m41t80_data->features & M41T80_FEATURE_HT) {
save_client = client;
Expand Down

0 comments on commit be8e274

Please sign in to comment.