Skip to content

Commit

Permalink
USB: drivers/usb/misc: Use an IS_ERR test rather than a NULL test
Browse files Browse the repository at this point in the history
In case of error, the function backlight_device_register returns an
ERR pointer, but never returns a NULL pointer. So a NULL test that may
come after a call to this function should be strengthened by an IS_ERR
test.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = backlight_device_register(...)
... when != x = E
* if (x != NULL) 
S1 else S2
// </smpl>

Signed-off-by: Julien Brunel <brunel@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Julien Brunel authored and Greg Kroah-Hartman committed Oct 17, 2008
1 parent 5820901 commit bedf088
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/misc/appledisplay.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ static int appledisplay_probe(struct usb_interface *iface,
pdata->urbdata, pdata->urb->transfer_dma);
usb_free_urb(pdata->urb);
}
if (pdata->bd)
if (pdata->bd && !IS_ERR(pdata->bd))
backlight_device_unregister(pdata->bd);
kfree(pdata->msgdata);
}
Expand Down

0 comments on commit bedf088

Please sign in to comment.