Skip to content

Commit

Permalink
i2c-viapro: Don't log nacks
Browse files Browse the repository at this point in the history
Transactions not acked can happen every now and then, in particular
during device detection, and various transaction types can be used for
this purpose. So stop logging this event, except when debugging is
enabled. This is what other similar drivers (e.g. i2c-i801 or
i2c-piix4) do.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
  • Loading branch information
Jean Delvare authored and Jean Delvare committed Oct 24, 2010
1 parent db79f2a commit bf5d95c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/i2c/busses/i2c-viapro.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,8 @@ static int vt596_transaction(u8 size)
}

if (temp & 0x04) {
int read = inb_p(SMBHSTADD) & 0x01;
result = -ENXIO;
/* The quick and receive byte commands are used to probe
for chips, so errors are expected, and we don't want
to frighten the user. */
if (!((size == VT596_QUICK && !read) ||
(size == VT596_BYTE && read)))
dev_err(&vt596_adapter.dev, "Transaction error!\n");
dev_dbg(&vt596_adapter.dev, "No response\n");
}

/* Resetting status register */
Expand Down

0 comments on commit bf5d95c

Please sign in to comment.