Skip to content

Commit

Permalink
[libata] pata_{legacy,sc1200,sl82c105}: add missing hooks
Browse files Browse the repository at this point in the history
Alan Cox noticed several hooks in pata_* drivers were missing, when
he authored his ->cable_detect hook patches.  This patch extracts
just those fixes from Alan's patches, adding the necessary hooks
(usually ->freeze, ->thaw, and ->post_internal_cmd) to the drivers.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Jeff Garzik committed Mar 2, 2007
1 parent f31f0cc commit bf7551c
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
18 changes: 18 additions & 0 deletions drivers/ata/pata_legacy.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ static struct ata_port_operations legacy_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
Expand Down Expand Up @@ -298,7 +301,10 @@ static struct ata_port_operations pdc20230_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
Expand Down Expand Up @@ -350,7 +356,10 @@ static struct ata_port_operations ht6560a_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
Expand Down Expand Up @@ -413,7 +422,10 @@ static struct ata_port_operations ht6560b_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
Expand Down Expand Up @@ -531,7 +543,10 @@ static struct ata_port_operations opti82c611a_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
Expand Down Expand Up @@ -661,7 +676,10 @@ static struct ata_port_operations opti82c46x_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.qc_prep = ata_qc_prep,
.qc_issue = opti82c46x_qc_issue_prot,
Expand Down
3 changes: 3 additions & 0 deletions drivers/ata/pata_sc1200.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,10 @@ static struct ata_port_operations sc1200_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.bmdma_setup = ata_bmdma_setup,
.bmdma_start = ata_bmdma_start,
Expand Down
3 changes: 3 additions & 0 deletions drivers/ata/pata_sl82c105.c
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,10 @@ static struct ata_port_operations sl82c105_port_ops = {
.exec_command = ata_exec_command,
.dev_select = ata_std_dev_select,

.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = sl82c105_error_handler,
.post_internal_cmd = ata_bmdma_post_internal_cmd,

.bmdma_setup = ata_bmdma_setup,
.bmdma_start = sl82c105_bmdma_start,
Expand Down

0 comments on commit bf7551c

Please sign in to comment.