Skip to content

Commit

Permalink
dma-mapping: support highmem in the generic remap allocator
Browse files Browse the repository at this point in the history
By using __dma_direct_alloc_pages we can deal entirely with struct page
instead of having to derive a kernel virtual address.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
  • Loading branch information
Christoph Hellwig committed Dec 1, 2018
1 parent 0c3b317 commit bfd56cd
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions kernel/dma/remap.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
gfp_t flags, unsigned long attrs)
{
struct page *page = NULL;
void *ret, *kaddr;
void *ret;

size = PAGE_ALIGN(size);

Expand All @@ -208,10 +208,9 @@ void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
return ret;
}

kaddr = dma_direct_alloc_pages(dev, size, dma_handle, flags, attrs);
if (!kaddr)
page = __dma_direct_alloc_pages(dev, size, dma_handle, flags, attrs);
if (!page)
return NULL;
page = virt_to_page(kaddr);

/* remove any dirty cache lines on the kernel alias */
arch_dma_prep_coherent(page, size);
Expand All @@ -221,18 +220,19 @@ void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
arch_dma_mmap_pgprot(dev, PAGE_KERNEL, attrs),
__builtin_return_address(0));
if (!ret)
dma_direct_free_pages(dev, size, kaddr, *dma_handle, attrs);
__dma_direct_free_pages(dev, size, page);
return ret;
}

void arch_dma_free(struct device *dev, size_t size, void *vaddr,
dma_addr_t dma_handle, unsigned long attrs)
{
if (!dma_free_from_pool(vaddr, PAGE_ALIGN(size))) {
void *kaddr = phys_to_virt(dma_to_phys(dev, dma_handle));
phys_addr_t phys = dma_to_phys(dev, dma_handle);
struct page *page = pfn_to_page(__phys_to_pfn(phys));

vunmap(vaddr);
dma_direct_free_pages(dev, size, kaddr, dma_handle, attrs);
__dma_direct_free_pages(dev, size, page);
}
}

Expand Down

0 comments on commit bfd56cd

Please sign in to comment.