Skip to content

Commit

Permalink
netfilter: ctnetlink: use EOPNOTSUPP instead of EINVAL if the conntra…
Browse files Browse the repository at this point in the history
…ck	has no helper

This patch changes the return value if the conntrack has no helper assigned.
Instead of EINVAL, which is reserved for malformed messages, it returns
EOPNOTSUPP.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
  • Loading branch information
Pablo Neira Ayuso authored and Patrick McHardy committed Nov 17, 2008
1 parent 238ede8 commit bfe2967
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netfilter/nf_conntrack_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1652,7 +1652,7 @@ ctnetlink_create_expect(struct nlattr *cda[], u_int8_t u3)

if (!help || !help->helper) {
/* such conntrack hasn't got any helper, abort */
err = -EINVAL;
err = -EOPNOTSUPP;
goto out;
}

Expand Down

0 comments on commit bfe2967

Please sign in to comment.