Skip to content

Commit

Permalink
m68knommu: fix broken boot logo inclusion
Browse files Browse the repository at this point in the history
Compiling for the m68knommu/68328 Palm/Pilot target you get:

  AS      arch/m68k/platform/68328/head-pilot.o
arch/m68k/platform/68328/head-pilot.S:37:23: fatal error: bootlogo.rh: No such file or directory

The build for this target used to do a conversion on a C coded boot logo
and include this in the head assembler code. This got broken by changes to
the local Makefile.

Clean all this up by just including the C coded boot logo struct in the
C code. With the appropriate alignment attribute there is no difference
to the way it can be used.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
  • Loading branch information
Greg Ungerer committed Dec 30, 2011
1 parent 40c1b9c commit c0e0c89
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 37 deletions.
6 changes: 1 addition & 5 deletions arch/m68k/platform/68328/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@ obj-$(CONFIG_M68328) += config.o
obj-$(CONFIG_ROM) += romvec.o

extra-y := head.o
extra-$(CONFIG_M68328) += bootlogo.rh head.o

$(obj)/bootlogo.rh: $(src)/bootlogo.h
perl $(src)/bootlogo.pl < $(src)/bootlogo.h > $(obj)/bootlogo.rh

$(obj)/head.o: $(obj)/$(head-y)
ln -sf $(head-y) $(obj)/head.o

clean-files := $(obj)/bootlogo.rh $(obj)/head.o $(head-y)
clean-files := $(obj)/head.o $(head-y)
2 changes: 1 addition & 1 deletion arch/m68k/platform/68328/bootlogo.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#define bootlogo_width 160
#define bootlogo_height 160
static unsigned char bootlogo_bits[] = {
unsigned char __attribute__ ((aligned(16))) bootlogo_bits[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x55, 0x01, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x40, 0x55, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
Expand Down
10 changes: 0 additions & 10 deletions arch/m68k/platform/68328/bootlogo.pl

This file was deleted.

3 changes: 3 additions & 0 deletions arch/m68k/platform/68328/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
#include <asm/system.h>
#include <asm/machdep.h>
#include <asm/MC68328.h>
#if defined(CONFIG_PILOT) || defined(CONFIG_INIT_LCD)
#include "bootlogo.h"
#endif

/***************************************************************************/

Expand Down
16 changes: 2 additions & 14 deletions arch/m68k/platform/68328/head-pilot.S
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,7 @@
.global _ramstart
.global _ramend

.global penguin_bits

#ifdef CONFIG_PILOT

#define IMR 0xFFFFF304

.data
.align 16

penguin_bits:
#include "bootlogo.rh"

#endif
.global bootlogo_bits

/*****************************************************************************/

Expand Down Expand Up @@ -196,7 +184,7 @@ L3:
DBG_PUTC('H')

#ifdef CONFIG_PILOT
movel #penguin_bits, 0xFFFFFA00
movel #bootlogo_bits, 0xFFFFFA00
moveb #10, 0xFFFFFA05
movew #160, 0xFFFFFA08
movew #160, 0xFFFFFA0A
Expand Down
9 changes: 2 additions & 7 deletions arch/m68k/platform/68328/head-rom.S
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
.global _ramend

#ifdef CONFIG_INIT_LCD
.global splash_bits
.global bootlogo_bits
#endif

.data
Expand All @@ -29,16 +29,11 @@ _ramend:

#define RAMEND (CONFIG_RAMBASE + CONFIG_RAMSIZE)

#ifdef CONFIG_INIT_LCD
splash_bits:
#include "bootlogo.rh"
#endif

.text
_start:
_stext: movew #0x2700,%sr
#ifdef CONFIG_INIT_LCD
movel #splash_bits, 0xfffffA00 /* LSSA */
movel #bootlogo_bits, 0xfffffA00 /* LSSA */
moveb #0x28, 0xfffffA05 /* LVPW */
movew #0x280, 0xFFFFFa08 /* LXMAX */
movew #0x1df, 0xFFFFFa0a /* LYMAX */
Expand Down

0 comments on commit c0e0c89

Please sign in to comment.