Skip to content

Commit

Permalink
soc: mediatek: mtk-devapc: Fix leaking IO map on error paths
Browse files Browse the repository at this point in the history
Error paths of mtk_devapc_probe() should unmap the memory.  Reported by
Smatch:

  drivers/soc/mediatek/mtk-devapc.c:292 mtk_devapc_probe() warn: 'ctx->infra_base' from of_iomap() not released on lines: 277,281,286.

Fixes: 0890beb ("soc: mediatek: add mt6779 devapc driver")
Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250104142012.115974-1-krzysztof.kozlowski@linaro.org
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  • Loading branch information
Krzysztof Kozlowski authored and AngeloGioacchino Del Regno committed Jan 7, 2025
1 parent 40384c8 commit c0eb059
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions drivers/soc/mediatek/mtk-devapc.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,23 +273,31 @@ static int mtk_devapc_probe(struct platform_device *pdev)
return -EINVAL;

devapc_irq = irq_of_parse_and_map(node, 0);
if (!devapc_irq)
return -EINVAL;
if (!devapc_irq) {
ret = -EINVAL;
goto err;
}

ctx->infra_clk = devm_clk_get_enabled(&pdev->dev, "devapc-infra-clock");
if (IS_ERR(ctx->infra_clk))
return -EINVAL;
if (IS_ERR(ctx->infra_clk)) {
ret = -EINVAL;
goto err;
}

ret = devm_request_irq(&pdev->dev, devapc_irq, devapc_violation_irq,
IRQF_TRIGGER_NONE, "devapc", ctx);
if (ret)
return ret;
goto err;

platform_set_drvdata(pdev, ctx);

start_devapc(ctx);

return 0;

err:
iounmap(ctx->infra_base);
return ret;
}

static void mtk_devapc_remove(struct platform_device *pdev)
Expand Down

0 comments on commit c0eb059

Please sign in to comment.