Skip to content

Commit

Permalink
Fix ARM to play nicely with generic Instrumentation menu
Browse files Browse the repository at this point in the history
The conflicting commit for
move-kconfiginstrumentation-to-arch-kconfig-and-init-kconfig.patch
is the ARM fix from Linus :

commit 38ad9ae

He just seemed to agree that my approach (just putting the missing ARM
config options in arch/arm/Kconfig) works too. The main advantage it has
is that it is smaller, does not need a cleanup in the future and does
not break the following patches unnecessarily.

It's just been discussed here

http://lkml.org/lkml/2008/1/15/267

However, Linus might prefer to stay with his own patch and I would
totally understand it that late in the release cycle. Therefore I submit
this for the next release cycle.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
CC: Russell King <rmk+lkml@arm.linux.org.uk>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
  • Loading branch information
Mathieu Desnoyers authored and Sam Ravnborg committed Feb 3, 2008
1 parent 603d498 commit c0ffa3a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 64 deletions.
19 changes: 18 additions & 1 deletion arch/arm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,23 @@ config FIQ
config ARCH_MTD_XIP
bool

if OPROFILE

config OPROFILE_ARMV6
def_bool y
depends on CPU_V6 && !SMP
select OPROFILE_ARM11_CORE

config OPROFILE_MPCORE
def_bool y
depends on CPU_V6 && SMP
select OPROFILE_ARM11_CORE

config OPROFILE_ARM11_CORE
bool

endif

config VECTORS_BASE
hex
default 0xffff0000 if MMU || CPU_HIGH_VECTOR
Expand Down Expand Up @@ -1128,7 +1145,7 @@ endmenu

source "fs/Kconfig"

source "arch/arm/Kconfig.instrumentation"
source "kernel/Kconfig.instrumentation"

source "arch/arm/Kconfig.debug"

Expand Down
62 changes: 0 additions & 62 deletions arch/arm/Kconfig.instrumentation

This file was deleted.

2 changes: 1 addition & 1 deletion kernel/Kconfig.instrumentation
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ config OPROFILE
config KPROBES
bool "Kprobes"
depends on KALLSYMS && MODULES && !UML
depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32
depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32 || (ARM && !XIP_KERNEL)
help
Kprobes allows you to trap at almost any kernel address and
execute a callback function. register_kprobe() establishes
Expand Down

0 comments on commit c0ffa3a

Please sign in to comment.