Skip to content

Commit

Permalink
net: stmmac: Do not return error code in TC Initialization
Browse files Browse the repository at this point in the history
As we can still use the remaining TC callbacks, e.g. CBS. We should not
fail in the initialization only because RX Parser is not available.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jose Abreu authored and David S. Miller committed Sep 5, 2019
1 parent 6338488 commit c104891
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,9 @@ static int tc_init(struct stmmac_priv *priv)
struct dma_features *dma_cap = &priv->dma_cap;
unsigned int count;

/* Fail silently as we can still use remaining features, e.g. CBS */
if (!dma_cap->frpsel)
return -EINVAL;
return 0;

switch (dma_cap->frpbs) {
case 0x0:
Expand Down

0 comments on commit c104891

Please sign in to comment.