Skip to content

Commit

Permalink
iio: accel: kxcjk-1013: Increment ref counter for indio_dev->trig
Browse files Browse the repository at this point in the history
Assigning indio_dev->trig is not a good idea, as this can result in
wrong reference count for trigger device. If assigned, it is better to
increment reference counter by calling iio_trigger_get.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Srinivas Pandruvada authored and Jonathan Cameron committed Jul 20, 2014
1 parent 59bfeab commit c1288b8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/iio/accel/kxcjk-1013.c
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ static int kxcjk1013_probe(struct i2c_client *client,
iio_trigger_set_drvdata(trig, indio_dev);
data->trig = trig;
indio_dev->trig = trig;
iio_trigger_get(indio_dev->trig);

ret = iio_trigger_register(trig);
if (ret)
Expand Down

0 comments on commit c1288b8

Please sign in to comment.