Skip to content

Commit

Permalink
x86/nmi: Fix timeout test in test_nmi_ipi()
Browse files Browse the repository at this point in the history
We're supposed to exit the loop with "timeout" set to zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Fixes: 99e8b9c ("x86, NMI: Add NMI IPI selftest")
Link: http://lkml.kernel.org/r/20170619105304.GA23995@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Dan Carpenter authored and Ingo Molnar committed Jun 20, 2017
1 parent 9705596 commit c133c76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/kernel/nmi_selftest.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static void __init test_nmi_ipi(struct cpumask *mask)

/* Don't wait longer than a second */
timeout = USEC_PER_SEC;
while (!cpumask_empty(mask) && timeout--)
while (!cpumask_empty(mask) && --timeout)
udelay(1);

/* What happens if we timeout, do we still unregister?? */
Expand Down

0 comments on commit c133c76

Please sign in to comment.