Skip to content

Commit

Permalink
staging: brcm80211: bugfix for fifo problem on 64 bits platforms.
Browse files Browse the repository at this point in the history
Message 'receive fifo overflow' appeared in the log. Root cause was an
invalid physical address being programmed into the DMA engine. This was
caused by an invalid pointer cast in the dma code. Issue was observed on
a Sparc (Sun Fire V120) machine but could theoretically also pop up
on other architectures.

Driver was tested to scan and ping on aforementioned machine.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Roland Vossen authored and Greg Kroah-Hartman committed Aug 23, 2011
1 parent 49d468f commit c13d2ad
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/staging/brcm80211/brcmsmac/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -600,13 +600,18 @@ static bool _dma_alloc(struct dma_info *di, uint direction)
void *dma_alloc_consistent(struct pci_dev *pdev, uint size, u16 align_bits,
uint *alloced, unsigned long *pap)
{
void *rc;
dma_addr_t dma_addr;

if (align_bits) {
u16 align = (1 << align_bits);
if (!IS_ALIGNED(PAGE_SIZE, align))
size += align;
*alloced = size;
}
return pci_alloc_consistent(pdev, size, (dma_addr_t *) pap);
rc = pci_alloc_consistent(pdev, size, &dma_addr);
*pap = dma_addr;
return rc;
}

/* !! may be called with core in reset */
Expand Down

0 comments on commit c13d2ad

Please sign in to comment.