Skip to content

Commit

Permalink
MIPS: Remove bogus BUG_ON()
Browse files Browse the repository at this point in the history
Checking for n<0 && n>9 makes no sense because it can never
be true. Moreover, we can have up to 64 vectored interrupts
so BUG_ON(n>9) was wrong anyway.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/5909/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Markos Chandras authored and Ralf Baechle committed Oct 29, 2013
1 parent a6e95a8 commit c1724c8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/mips/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,6 @@ static void *set_vi_srs_handler(int n, vi_handler_t addr, int srs)
unsigned char *b;

BUG_ON(!cpu_has_veic && !cpu_has_vint);
BUG_ON((n < 0) && (n > 9));

if (addr == NULL) {
handler = (unsigned long) do_default_vi;
Expand Down

0 comments on commit c1724c8

Please sign in to comment.