Skip to content

Commit

Permalink
TTY: ircomm, use GFP_KERNEL in ircomm_open()
Browse files Browse the repository at this point in the history
Hi Greg,

I'm unsure if you or Dave should take that one as it's for one a TTY
patch but also living under net/. So I'm uncertain and let you decide!

Thanks,
Mathias

-- >8 --
Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()

We're clearly running in non-atomic context as our only call site is
able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL
here instead of GFP_ATOMIC.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Mathias Krause authored and David S. Miller committed Apr 8, 2013
1 parent e1e3c80 commit c17277f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/irda/ircomm/ircomm_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ struct ircomm_cb *ircomm_open(notify_t *notify, __u8 service_type, int line)

IRDA_ASSERT(ircomm != NULL, return NULL;);

self = kzalloc(sizeof(struct ircomm_cb), GFP_ATOMIC);
self = kzalloc(sizeof(struct ircomm_cb), GFP_KERNEL);
if (self == NULL)
return NULL;

Expand Down

0 comments on commit c17277f

Please sign in to comment.