Skip to content

Commit

Permalink
drm/panel/panel-sitronix-st7701: Fix RTNI calculation
Browse files Browse the repository at this point in the history
The RTNI field is multiplied by 16 and incremented by 512 before being
used as the minimum number of pixel clock per horizontal line, hence
it is necessary to subtract those 512 bytes from htotal and then divide
the result by 16 before writing the value into the RTNI field. Fix the
calculation.

Fixes: de2b491 ("drm/panel/panel-sitronix-st7701: Infer horizontal pixel count from TFT mode")
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20221012221159.88397-1-marex@denx.de
  • Loading branch information
Marek Vasut committed Nov 1, 2022
1 parent 2215cb3 commit c1cdee9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/panel/panel-sitronix-st7701.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ static void st7701_init_sequence(struct st7701 *st7701)
DSI_CMD2_BK0_INVSEL_ONES_MASK |
FIELD_PREP(DSI_CMD2_BK0_INVSEL_NLINV_MASK, desc->nlinv),
FIELD_PREP(DSI_CMD2_BK0_INVSEL_RTNI_MASK,
DIV_ROUND_UP(mode->htotal, 16)));
(clamp((u32)mode->htotal, 512U, 1008U) - 512) / 16));

/* Command2, BK1 */
ST7701_DSI(st7701, DSI_CMD2BKX_SEL,
Expand Down

0 comments on commit c1cdee9

Please sign in to comment.