Skip to content

Commit

Permalink
net: sctp: sctp_ulpq: remove 'malloced' struct member
Browse files Browse the repository at this point in the history
The structure sctp_ulpq is embedded into sctp_association and never
separately allocated, also ulpq->malloced is always 0, so that
kfree() is never called. Therefore, remove this code.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Daniel Borkmann authored and David S. Miller committed Apr 17, 2013
1 parent 50181c0 commit c1db7a2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion include/net/sctp/ulpqueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@

/* A structure to carry information to the ULP (e.g. Sockets API) */
struct sctp_ulpq {
char malloced;
char pd_mode;
struct sctp_association *asoc;
struct sk_buff_head reasm;
Expand Down
3 changes: 0 additions & 3 deletions net/sctp/ulpqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ struct sctp_ulpq *sctp_ulpq_init(struct sctp_ulpq *ulpq,
skb_queue_head_init(&ulpq->reasm);
skb_queue_head_init(&ulpq->lobby);
ulpq->pd_mode = 0;
ulpq->malloced = 0;

return ulpq;
}
Expand Down Expand Up @@ -96,8 +95,6 @@ void sctp_ulpq_flush(struct sctp_ulpq *ulpq)
void sctp_ulpq_free(struct sctp_ulpq *ulpq)
{
sctp_ulpq_flush(ulpq);
if (ulpq->malloced)
kfree(ulpq);
}

/* Process an incoming DATA chunk. */
Expand Down

0 comments on commit c1db7a2

Please sign in to comment.