Skip to content

Commit

Permalink
s390/qeth: convert sysfs snprintf to sysfs_emit
Browse files Browse the repository at this point in the history
Follow the advice of the Documentation/filesystems/sysfs.rst
and show() should only use sysfs_emit() or sysfs_emit_at()
when formatting the value to be returned to user space.

Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Xuezhi Zhang authored and David S. Miller committed Dec 28, 2022
1 parent 0e3d183 commit c205218
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/s390/net/qeth_core_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -410,13 +410,13 @@ static ssize_t qeth_dev_isolation_show(struct device *dev,

switch (card->options.isolation) {
case ISOLATION_MODE_NONE:
return snprintf(buf, 6, "%s\n", ATTR_QETH_ISOLATION_NONE);
return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_NONE);
case ISOLATION_MODE_FWD:
return snprintf(buf, 9, "%s\n", ATTR_QETH_ISOLATION_FWD);
return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_FWD);
case ISOLATION_MODE_DROP:
return snprintf(buf, 6, "%s\n", ATTR_QETH_ISOLATION_DROP);
return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_DROP);
default:
return snprintf(buf, 5, "%s\n", "N/A");
return sysfs_emit(buf, "%s\n", "N/A");
}
}

Expand Down Expand Up @@ -500,9 +500,9 @@ static ssize_t qeth_hw_trap_show(struct device *dev,
struct qeth_card *card = dev_get_drvdata(dev);

if (card->info.hwtrap)
return snprintf(buf, 5, "arm\n");
return sysfs_emit(buf, "arm\n");
else
return snprintf(buf, 8, "disarm\n");
return sysfs_emit(buf, "disarm\n");
}

static ssize_t qeth_hw_trap_store(struct device *dev,
Expand Down

0 comments on commit c205218

Please sign in to comment.