Skip to content

Commit

Permalink
perf tools: Fix find tids routine by excluding "." and ".."
Browse files Browse the repository at this point in the history
Introduce a filter function to skip "." and ".." directories when calculating
tid number, otherwise tid 0 will be included in the all_tid result array.

Cc: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <4C185F68.1020505@cn.fujitsu.com>
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Gui Jianfeng authored and Arnaldo Carvalho de Melo committed Jul 1, 2010
1 parent a1e80fa commit c214909
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion tools/perf/util/thread.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@
#include "util.h"
#include "debug.h"

/* Skip "." and ".." directories */
static int filter(const struct dirent *dir)
{
if (dir->d_name[0] == '.')
return 0;
else
return 1;
}

int find_all_tid(int pid, pid_t ** all_tid)
{
char name[256];
Expand All @@ -16,7 +25,7 @@ int find_all_tid(int pid, pid_t ** all_tid)
int i;

sprintf(name, "/proc/%d/task", pid);
items = scandir(name, &namelist, NULL, NULL);
items = scandir(name, &namelist, filter, NULL);
if (items <= 0)
return -ENOENT;
*all_tid = malloc(sizeof(pid_t) * items);
Expand Down

0 comments on commit c214909

Please sign in to comment.