Skip to content

Commit

Permalink
net: lpc_eth: avoid resetting twice
Browse files Browse the repository at this point in the history
__lpc_eth_shutdown is called after __lpc_eth_reset but it is already
calling __lpc_eth_reset. Avoid resetting the IP twice.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexandre Belloni authored and David S. Miller committed Oct 13, 2019
1 parent 3f23380 commit c23936f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/nxp/lpc_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1356,9 +1356,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
if (!is_valid_ether_addr(ndev->dev_addr))
eth_hw_addr_random(ndev);

/* Reset the ethernet controller */
__lpc_eth_reset(pldat);

/* then shut everything down to save power */
__lpc_eth_shutdown(pldat);

Expand Down

0 comments on commit c23936f

Please sign in to comment.