Skip to content

Commit

Permalink
Revert "ACPICA: executer/exsystem: Warn about sleeps greater than 10 ms"
Browse files Browse the repository at this point in the history
Commit 6eaf087 ("ACPICA: executer/exsystem: Warn about sleeps
greater than 10 ms") made acpi_ex_system_do_sleep() log a warning for
sleep times greater than 10 ms, but such sleep times are used in
power management AML because of the PCI specification requirements.

This results with logging warnings that cannot really be acted on in
any useful way which is annoying and these warnings show up in the logs
on many production systems, so revert commit 6eaf087.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Rafael J. Wysocki committed May 21, 2022
1 parent 0076ca9 commit c244dc1
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions drivers/acpi/acpica/exsystem.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,17 +169,6 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)

acpi_ex_exit_interpreter();

/*
* Warn users about excessive sleep times, so ASL code can be improved to
* use polling or similar techniques.
*/
if (how_long_ms > 10) {
ACPI_WARNING((AE_INFO,
"Firmware issue: Excessive sleep time (0x%8.8X%8.8X ms > 10 ms)"
" in ACPI Control Method",
ACPI_FORMAT_UINT64(how_long_ms)));
}

/*
* For compatibility with other ACPI implementations and to prevent
* accidental deep sleeps, limit the sleep time to something reasonable.
Expand Down

0 comments on commit c244dc1

Please sign in to comment.