Skip to content

Commit

Permalink
netdevsim: don't leak devlink resources
Browse files Browse the repository at this point in the history
Devlink resources registered with devlink_resource_register() have
to be unregistered.

Fixes: 37923ed ("netdevsim: Add simple FIB resource controller via devlink")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jakub Kicinski authored and David S. Miller committed Jul 26, 2018
1 parent b87bac1 commit c259b4f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/netdevsim/devlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ void nsim_devlink_teardown(struct netdevsim *ns)
struct net *net = nsim_to_net(ns);
bool *reg_devlink = net_generic(net, nsim_devlink_id);

devlink_resources_unregister(ns->devlink, NULL);
devlink_unregister(ns->devlink);
devlink_free(ns->devlink);
ns->devlink = NULL;
Expand Down

0 comments on commit c259b4f

Please sign in to comment.