Skip to content

Commit

Permalink
iio: light: bh1750: constify attribute_group structures
Browse files Browse the repository at this point in the history
Check for attribute_group structures that are only stored in the
attrs filed of iio_info structure. As the attrs field of iio_info
structures is constant, so these attribute_group structures can also be
declared constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text	   data	    bss	    dec	    hex	filename
   2276	    352	      0	   2628	    a44	drivers/iio/light/bh1750.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   2340	    320	      0	   2660	    a64	drivers/iio/light/bh1750.o

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
simran singhal authored and Jonathan Cameron committed Apr 1, 2017
1 parent 7ab89e1 commit c286949
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iio/light/bh1750.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ static struct attribute *bh1750_attributes[] = {
NULL,
};

static struct attribute_group bh1750_attribute_group = {
static const struct attribute_group bh1750_attribute_group = {
.attrs = bh1750_attributes,
};

Expand Down

0 comments on commit c286949

Please sign in to comment.