Skip to content

Commit

Permalink
net: ipv6: minor: *_start_timer: rather use unsigned long
Browse files Browse the repository at this point in the history
For the functions mld_gq_start_timer(), mld_ifc_start_timer(),
and mld_dad_start_timer(), rather use unsigned long than int
as we operate only on unsigned values anyway. This seems more
appropriate as there is no good reason to do type conversions
to int, that could lead to future errors.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Daniel Borkmann authored and David S. Miller committed Aug 21, 2013
1 parent 8469896 commit c2cef4e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions net/ipv6/mcast.c
Original file line number Diff line number Diff line change
Expand Up @@ -996,24 +996,24 @@ bool ipv6_chk_mcast_addr(struct net_device *dev, const struct in6_addr *group,

static void mld_gq_start_timer(struct inet6_dev *idev)
{
int tv = net_random() % idev->mc_maxdelay;
unsigned long tv = net_random() % idev->mc_maxdelay;

idev->mc_gq_running = 1;
if (!mod_timer(&idev->mc_gq_timer, jiffies+tv+2))
in6_dev_hold(idev);
}

static void mld_ifc_start_timer(struct inet6_dev *idev, int delay)
static void mld_ifc_start_timer(struct inet6_dev *idev, unsigned long delay)
{
int tv = net_random() % delay;
unsigned long tv = net_random() % delay;

if (!mod_timer(&idev->mc_ifc_timer, jiffies+tv+2))
in6_dev_hold(idev);
}

static void mld_dad_start_timer(struct inet6_dev *idev, int delay)
static void mld_dad_start_timer(struct inet6_dev *idev, unsigned long delay)
{
int tv = net_random() % delay;
unsigned long tv = net_random() % delay;

if (!mod_timer(&idev->mc_dad_timer, jiffies+tv+2))
in6_dev_hold(idev);
Expand Down

0 comments on commit c2cef4e

Please sign in to comment.