Skip to content

Commit

Permalink
drivers/misc/sgi-gru: remove always false condition
Browse files Browse the repository at this point in the history
The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
it can never be less than 0.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sudip Mukherjee authored and Greg Kroah-Hartman committed Sep 21, 2015
1 parent 1126bc2 commit c2ed545
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/misc/sgi-gru/grukdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ int gru_dump_chiplet_request(unsigned long arg)
return -EFAULT;

/* Currently, only dump by gid is implemented */
if (req.gid >= gru_max_gids || req.gid < 0)
if (req.gid >= gru_max_gids)
return -EINVAL;

gru = GID_TO_GRU(req.gid);
Expand Down

0 comments on commit c2ed545

Please sign in to comment.