Skip to content

Commit

Permalink
dsa: Remove master_dev from switch structure
Browse files Browse the repository at this point in the history
The switch drivers only use the master_dev member for dev_info()
messages.  Now that the device is passed to the old style probe, and
new style drivers are probed as true linux drivers, this is no longer
needed.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andrew Lunn authored and David S. Miller committed May 11, 2016
1 parent 52638f7 commit c33063d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
1 change: 1 addition & 0 deletions drivers/net/dsa/mv88e6xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -3642,6 +3642,7 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev)

ps = (struct mv88e6xxx_priv_state *)(ds + 1);
ds->priv = ps;
ds->dev = dev;
ps->dev = dev;
ps->ds = ds;
ps->bus = mdiodev->bus;
Expand Down
7 changes: 2 additions & 5 deletions include/net/dsa.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ struct dsa_switch_tree {
};

struct dsa_switch {
struct device *dev;

/*
* Parent switch tree, and switch index.
*/
Expand All @@ -142,11 +144,6 @@ struct dsa_switch {
*/
struct dsa_switch_driver *drv;

/*
* Reference to host device to use.
*/
struct device *master_dev;

#ifdef CONFIG_NET_DSA_HWMON
/*
* Hardware monitoring information
Expand Down
2 changes: 1 addition & 1 deletion net/dsa/dsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
ds->pd = pd;
ds->drv = drv;
ds->priv = priv;
ds->master_dev = host_dev;
ds->dev = parent;

ret = dsa_switch_setup_one(ds, parent);
if (ret)
Expand Down
2 changes: 1 addition & 1 deletion net/dsa/slave.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds)
ds->slave_mii_bus->write = dsa_slave_phy_write;
snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d:%.2x",
ds->index, ds->pd->sw_addr);
ds->slave_mii_bus->parent = ds->master_dev;
ds->slave_mii_bus->parent = ds->dev;
ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask;
}

Expand Down

0 comments on commit c33063d

Please sign in to comment.