Skip to content

Commit

Permalink
dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_requ…
Browse files Browse the repository at this point in the history
…est()

An SMBIOS buffer pointer does not need to be returned by
dell_smbios_send_request(), because SMBIOS call results are stored in
the buffer exported by the module.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
  • Loading branch information
Michał Kępień authored and Darren Hart committed Mar 23, 2016
1 parent 17070f2 commit c42831c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 1 addition & 4 deletions drivers/platform/x86/dell-smbios.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ void dell_smbios_release_buffer(void)
}
EXPORT_SYMBOL_GPL(dell_smbios_release_buffer);

struct calling_interface_buffer *
dell_smbios_send_request(int class, int select)
void dell_smbios_send_request(int class, int select)
{
struct smi_cmd command;

Expand All @@ -75,8 +74,6 @@ dell_smbios_send_request(int class, int select)
buffer->select = select;

dcdbas_smi_request(&command);

return buffer;
}
EXPORT_SYMBOL_GPL(dell_smbios_send_request);

Expand Down
3 changes: 1 addition & 2 deletions drivers/platform/x86/dell-smbios.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ extern struct calling_interface_token *da_tokens;
void dell_smbios_get_buffer(void);
void dell_smbios_clear_buffer(void);
void dell_smbios_release_buffer(void);
struct calling_interface_buffer *
dell_smbios_send_request(int class, int select);
void dell_smbios_send_request(int class, int select);

int find_token_id(int tokenid);
int find_token_location(int tokenid);
Expand Down

0 comments on commit c42831c

Please sign in to comment.