Skip to content

Commit

Permalink
xen/swiotlb: For early initialization, return zero on success.
Browse files Browse the repository at this point in the history
If everything is setup properly we would return -ENOMEM since
rc by default is set to that value. Lets not do that and return
a proper return code.

Note: The reason the early code needs this special treatment
is that it SWIOTLB library call does not return anything (and
had it failed it would call panic()) - but our function does.

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Konrad Rzeszutek Wilk committed Sep 17, 2012
1 parent b827760 commit c468bde
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/xen/swiotlb-xen.c
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,10 @@ int __ref xen_swiotlb_init(int verbose, bool early)
goto error;
}
start_dma_addr = xen_virt_to_bus(xen_io_tlb_start);
if (early)
if (early) {
swiotlb_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs, verbose);
else
rc = 0;
} else
rc = swiotlb_late_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs);
return rc;
error:
Expand Down

0 comments on commit c468bde

Please sign in to comment.