Skip to content

Commit

Permalink
net: Remove superfluous setting of key_basic
Browse files Browse the repository at this point in the history
key_basic is set twice in __skb_flow_dissect which seems unnecessary.
Remove second one.

Acked-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tom Herbert authored and David S. Miller committed Jun 4, 2015
1 parent 730fc43 commit c468efe
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions net/core/flow_dissector.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,6 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
break;
}

/* It is ensured by skb_flow_dissector_init() that basic key will
* be always present.
*/
key_basic = skb_flow_dissector_target(flow_dissector,
FLOW_DISSECTOR_KEY_BASIC,
target_container);
key_basic->n_proto = proto;
key_basic->ip_proto = ip_proto;
key_basic->thoff = (u16) nhoff;
Expand Down

0 comments on commit c468efe

Please sign in to comment.