Skip to content

Commit

Permalink
drm/lima: avoid error task dump attempt when not enabled
Browse files Browse the repository at this point in the history
Currently when users try to run an application with lima and that hits
an issue such as a timeout, a message saying "fail to save task state"
and "error task list is full" is shown in dmesg.

The error task dump is a debug feature disabled by default, so the
error task list is usually not going to be available at all.
The message can be misleading and creates confusion in bug reports.

We can avoid that code path and that particular message when the user
has not explicitly set the max_error_tasks parameter to enable the
feature.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220209093700.30901-1-nunes.erico@gmail.com
  • Loading branch information
Erico Nunes authored and Qiang Yu committed Feb 12, 2022
1 parent c7703ce commit c49fcb5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/lima/lima_sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,8 @@ static enum drm_gpu_sched_stat lima_sched_timedout_job(struct drm_sched_job *job

drm_sched_increase_karma(&task->base);

lima_sched_build_error_task_list(task);
if (lima_max_error_tasks)
lima_sched_build_error_task_list(task);

pipe->task_error(pipe);

Expand Down

0 comments on commit c49fcb5

Please sign in to comment.