Skip to content

Commit

Permalink
cfq-iosched: removing unnecessary think time checking
Browse files Browse the repository at this point in the history
Removing think time checking. A high thinktime queue might means the queue
dispatches several requests and then do away. Limitting such queue seems
meaningless. And also this can simplify code. This is suggested by Vivek.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
  • Loading branch information
Li, Shaohua authored and Jens Axboe committed Mar 23, 2011
1 parent 62a37f6 commit c4ade94
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -2417,19 +2417,14 @@ static bool cfq_may_dispatch(struct cfq_data *cfqd, struct cfq_queue *cfqq)
return false;

/*
* If there is only one sync queue, and its think time is
* small, we can ignore async queue here and give the sync
* If there is only one sync queue
* we can ignore async queue here and give the sync
* queue no dispatch limit. The reason is a sync queue can
* preempt async queue, limiting the sync queue doesn't make
* sense. This is useful for aiostress test.
*/
if (cfq_cfqq_sync(cfqq) && cfqd->busy_sync_queues == 1) {
struct cfq_io_context *cic = RQ_CIC(cfqq->next_rq);

if (sample_valid(cic->ttime_samples) &&
cic->ttime_mean < cfqd->cfq_slice_idle)
promote_sync = true;
}
if (cfq_cfqq_sync(cfqq) && cfqd->busy_sync_queues == 1)
promote_sync = true;

/*
* We have other queues, don't allow more IO from this one
Expand Down

0 comments on commit c4ade94

Please sign in to comment.