Skip to content

Commit

Permalink
dt-bindings: input: gpio-keys: Fix interrupts in example
Browse files Browse the repository at this point in the history
The "interrupts" property in the example looks weird:
  - The type is not in the last cell,
  - Level interrupts don't work well with gpio-keys, as they keep the
    interrupt asserted as long as the key is pressed, causing an
    interrupt storm.

Use a more realistic falling-edge interrupt instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
  • Loading branch information
Geert Uytterhoeven authored and Rob Herring committed Dec 6, 2021
1 parent 96db48c commit c4cb38b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Documentation/devicetree/bindings/input/gpio-keys.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ examples:
down {
label = "GPIO Key DOWN";
linux,code = <108>;
interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
};
};
Expand Down

0 comments on commit c4cb38b

Please sign in to comment.