Skip to content

Commit

Permalink
serial: sprd: Fix missing spin_unlock in sprd_handle_irq()
Browse files Browse the repository at this point in the history
Fix return from sprd_handle_irq() with spin_lock held.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Axel Lin authored and Greg Kroah-Hartman committed Mar 7, 2015
1 parent 30a22c2 commit c4e6dcf
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/tty/serial/sprd_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,10 @@ static irqreturn_t sprd_handle_irq(int irq, void *dev_id)

ims = serial_in(port, SPRD_IMSR);

if (!ims)
if (!ims) {
spin_unlock(&port->lock);
return IRQ_NONE;
}

serial_out(port, SPRD_ICLR, ~0);

Expand Down

0 comments on commit c4e6dcf

Please sign in to comment.