Skip to content

Commit

Permalink
drm/i915/icl: don't set CNL_DDI_CLOCK_REG_ACCESS_ON anymore
Browse files Browse the repository at this point in the history
The new recommendation from the spec is to simply not set this bit
anymore. Not setting the bit would prevent some hangs that our driver
manages to avoid since commit c8af527 ("drm/i915: enable the
pipe/transcoder/planes later on HSW+"), and the theoretical downside
of not setting the bit doesn't seem realistic according to the HW
team. Let's follow their recommendation.

BSpec: 20233
References: commit c8af527 ("drm/i915: enable the
 pipe/transcoder/planes later on HSW+")
Cc: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180726001229.13791-1-paulo.r.zanoni@intel.com
  • Loading branch information
Paulo Zanoni committed Jul 27, 2018
1 parent 5503cb0 commit c50dfe7
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/gpu/drm/i915/intel_runtime_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -3372,10 +3372,6 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,

/* 7. Setup MBUS. */
icl_mbus_init(dev_priv);

/* 8. CHICKEN_DCPR_1 */
I915_WRITE(GEN8_CHICKEN_DCPR_1, I915_READ(GEN8_CHICKEN_DCPR_1) |
CNL_DDI_CLOCK_REG_ACCESS_ON);
}

static void icl_display_core_uninit(struct drm_i915_private *dev_priv)
Expand Down

0 comments on commit c50dfe7

Please sign in to comment.