Skip to content

Commit

Permalink
powerpc/8xx: fix cpm_cascade() dual end of interrupt
Browse files Browse the repository at this point in the history
cpm_cascade() doesn't have to call eoi() as it is already called
by handle_fasteoi_irq()

And cpm_get_irq() will always return an unsigned int so the test
is useless

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Christophe Leroy authored and Michael Ellerman committed Mar 13, 2018
1 parent 3d4f5f5 commit c554ac9
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions arch/powerpc/platforms/8xx/m8xx_setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,7 @@ void __noreturn mpc8xx_restart(char *cmd)

static void cpm_cascade(struct irq_desc *desc)
{
struct irq_chip *chip = irq_desc_get_chip(desc);
int cascade_irq = cpm_get_irq();

if (cascade_irq >= 0)
generic_handle_irq(cascade_irq);

chip->irq_eoi(&desc->irq_data);
generic_handle_irq(cpm_get_irq());
}

/* Initialize the internal interrupt controllers. The number of
Expand Down

0 comments on commit c554ac9

Please sign in to comment.