Skip to content

Commit

Permalink
viafb: reduce OLPC refresh a bit
Browse files Browse the repository at this point in the history
When allowing some PLL calculation we get a frequency that seems to
be a bit higher than what the OLPC DCON likes resulting in a still
readable but not so good image. We don't really know whether this is
a problem with the calculation formula or the OLPC but as other
displays seem to be happy with the other modes adjusting the OLPC
refresh looks like the better thing. This patch prevents a
regression when dynamic PLL calculation is allowed.

Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Florian Tobias Schandinat authored and Florian Tobias Schandinat committed Apr 23, 2011
1 parent 32fab7b commit c5a4e6d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/video/via/hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -2605,7 +2605,7 @@ int viafb_get_refresh(int hres, int vres, u32 long_refresh)

if (abs(best->refresh_rate - long_refresh) > 3) {
if (hres == 1200 && vres == 900)
return 50; /* OLPC DCON only supports 50 Hz */
return 49; /* OLPC DCON only supports 50 Hz */
else
return 60;
}
Expand Down
1 change: 1 addition & 0 deletions drivers/video/via/share.h
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@
#define HW_LAYOUT_LCD_EXTERNAL_LCD2 0x10

/* Definition Refresh Rate */
#define REFRESH_49 49
#define REFRESH_50 50
#define REFRESH_60 60
#define REFRESH_75 75
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/via/viamode.c
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ static struct crt_mode_table CRTM1200x720[] = {
/* 1200x900 (DCON) */
static struct crt_mode_table DCON1200x900[] = {
/* r_rate, hsp, vsp */
{REFRESH_50, M1200X900_R60_HSP, M1200X900_R60_VSP,
{REFRESH_49, M1200X900_R60_HSP, M1200X900_R60_VSP,
/* The correct htotal is 1240, but this doesn't raster on VX855. */
/* Via suggested changing to a multiple of 16, hence 1264. */
/* HT, HA, HBS, HBE, HSS, HSE, VT, VA, VBS, VBE, VSS, VSE */
Expand Down

0 comments on commit c5a4e6d

Please sign in to comment.