Skip to content

Commit

Permalink
platform/x86: hp-bioscfg: Simplify return check in hp_add_other_attri…
Browse files Browse the repository at this point in the history
…butes()

All cases in switch-case have a same goto on error, move the return
check out of the switch. This is a cleanup.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231113200742.3593548-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
  • Loading branch information
Harshit Mogalapalli authored and Ilpo Järvinen committed Nov 15, 2023
1 parent 7a3c36e commit c5dbf04
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
Original file line number Diff line number Diff line change
Expand Up @@ -630,21 +630,19 @@ static int hp_add_other_attributes(int attr_type)
switch (attr_type) {
case HPWMI_SECURE_PLATFORM_TYPE:
ret = hp_populate_secure_platform_data(attr_name_kobj);
if (ret)
goto err_other_attr_init;
break;

case HPWMI_SURE_START_TYPE:
ret = hp_populate_sure_start_data(attr_name_kobj);
if (ret)
goto err_other_attr_init;
break;

default:
ret = -EINVAL;
goto err_other_attr_init;
}

if (ret)
goto err_other_attr_init;

mutex_unlock(&bioscfg_drv.mutex);
return 0;

Expand Down

0 comments on commit c5dbf04

Please sign in to comment.